Allow removal of rel for Terms and Privacy skin objects #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e skin Set the rel attribute of the hyperlink only if there is either no value set in the skin or a non blank value defined in the skin. If it is set to rel="" in the skin, the hyperlink will be rendered without a rel attribute.
bdukes
approved these changes
Mar 21, 2022
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
valadas
changed the title
valadas
approved these changes
Mar 22, 2022
|
I have added a summary to the Getter/Setter for the Rel attribute for the Privacy and Terms skin objects. ("Gets or sets the rel attribute of the Privacy/Terms skin object. Set it to an empty string to not render a rel attribute at all."). I made that change on my local branch ("Fix-for-issue-#5047"). Can I still submit that now? Or do I need to make a new branch and new PR for that? What would be the best approach? |
|
You can use the same branch, but it needs to be a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the rel attribute of the hyperlink only if there is either no value set in the skin or a non blank value defined in the skin. If it is set to rel="" in the skin, the hyperlink will be rendered without a rel attribute.
Fixes #5047
Summary