Fix bug - postback issue with the cke editor #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
It looks like @zyhfish introduced the current behavior in 9.8.0 (cf. 88a9b4e). This PR would revert to the previous behavior, except it replaces It looks like that change was supposed to address DNN-Connect/CKEditorProvider#136 (which sounds similar to #3469 that had the fix applied here) |
|
@skamphuis or @Timo-Breumelhof Do you have any insight on this one by chance since you have been in the editor? |
|
I'm happy to have a look tomorrow. |
|
@mitchelsellers I tested this change and indeed it does fix the issue as described in #4709 . Saving changes in both editor mode and basic text mode keeps working. Good catch, @nellaaayyy |
mitchelsellers
approved these changes
Jul 5, 2022
david-poindexter
approved these changes
Jul 5, 2022
no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4709
Summary
CKE Editor disappears on postback. Returning false will stop the postback from happening.