Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicated some code in audit check unit test #5081

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Deduplicated some code in audit check unit test #5081

merged 2 commits into from
Apr 10, 2022

Conversation

daguiler
Copy link
Contributor

This is a small addendum to #5080.

  • The summary of CheckUserProfilePage was still referencing the portal registration type.
  • There was a small bit of duplicate code in one of the unit tests.

@david-poindexter david-poindexter added this to the 9.11.0 milestone Apr 10, 2022
@david-poindexter
Copy link
Contributor

Related to #4948

@valadas valadas changed the title Addendum to #5080 Deduplicated some code in audit check unit test Apr 10, 2022
@valadas valadas modified the milestones: 9.11.0, 9.10.3 Apr 10, 2022
valadas
valadas approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, clean code!

@valadas valadas merged commit 3620205 into dnnsoftware:develop Apr 10, 2022
@daguiler daguiler deleted the addendum-to-5080 branch April 10, 2022 18:54
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daguiler @david-poindexter @valadas