Removed two unused utility methods that depended on momentjs
#5082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
valadas
approved these changes
Apr 10, 2022
mitchelsellers
approved these changes
Apr 11, 2022
bdukes
approved these changes
Apr 11, 2022
I would be shocked if there is any external use of these rogue functions. |
|
I would be extremely surprised if any 3rd party even knows those functions are there + it's not a package or a library, I consider this internal code myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These two utility methods are unused and they depended on
momentjs. Instead of swapping out fordayjsI felt it best to remove the methods instead.This PR relates to #3875