Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade momentjs to 2.29.2 #5083

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

david-poindexter
Copy link
Contributor

@david-poindexter david-poindexter commented Apr 10, 2022

Summary

We use a third-party JS DatePicker in our DnnDatePicker control, as well as within the PersonaBar. The third-party JS DatePicker, Pikaday, unfortunately depends (optionally) on momentjs. This PR addresses the need to upgrade momentjs to the latest release. We were using v2.5.1 in DnnDatePicker and v2.8.1 in the PersonaBar. v2.29.2 was released 7 days ago, so this brings us up to date with momentjs.

Related to #3875

@david-poindexter
Copy link
Contributor Author

I failed to mention the testing I did. I tested the DnnDatePicker control in the HTML module settings > Advanced Settings for Start Date and End Date. All worked as expected.

Likewise, I tested in multiple places in the PersonaBar:

  • Add user to Role with Start and Expires date
  • Enable Scheduling on page settings to set a Start Date and End Date

All worked as expected.

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the scenarios outlined, all good

@bdukes bdukes added this to the 9.10.3 milestone Apr 11, 2022
@bdukes
Copy link
Contributor

bdukes commented Apr 11, 2022

I pushed an extra commit to upgrade the version used via npm/yarn

@david-poindexter
Copy link
Contributor Author

I pushed an extra commit to upgrade the version used via npm/yarn

Oh, good catch @bdukes - thank you!

@bdukes bdukes merged commit fb3dc38 into dnnsoftware:develop Apr 11, 2022
@david-poindexter david-poindexter deleted the momentjs-upgrade branch April 11, 2022 17:45
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants