Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the underlying FileInstaller to delete the file if needed. #5087

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Allow the underlying FileInstaller to delete the file if needed. #5087

merged 1 commit into from
Apr 12, 2022

Conversation

dimarobert
Copy link
Contributor

Fixes #5025.

Summary

Ensures that the FileInstaller.DeleteFiles flag is set to true when UnRegister-ing an Assembly file in the AssemblyInstaller.

donker
donker approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this.

mitchelsellers
mitchelsellers approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a feature that appears to have been non-functional for a long time. We did discuss in the Approvers meeting today that there is a potential for a module that wasn't good with assembly registration to be broken by this fix.

@donker donker added this to the 9.11.0 milestone Apr 12, 2022
@donker donker modified the milestones: 9.11.0, 9.10.3 Apr 12, 2022
@donker donker merged commit dd55f7f into dnnsoftware:develop Apr 12, 2022
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donker donker donker approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
Area: Platform > Library Noteworthy Type: Bug
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.

AssemblyInstaller does not delete the file when UnRegister is specified.
4 participants
@dimarobert @donker @mitchelsellers @valadas