Add folder cleanup support to CleanupInstaller

[daguiler]

Summary

The CleanupInstaller class supports a glob parameter that works well, but leaves an empty folder structure behind after deleting all files.
This pull request adds support for a new <folder> element in the package schema that allows for recursive folder deletion.

Usage:

<dotnetnuke type="Package" version="5.0">
    <packages>
        <package name="..." type="Provider" version="02.00.00">
            <friendlyName>...</friendlyName>
            ...
            <components>
                ...
                <component type="Cleanup">
                    <files>
                        ...
                    </files>
                    <folder>
                        <path>Providers/HtmlEditorProviders/MyProvider/1.0.0</path>
                    </folder>
                    <folder>
                        <path>Providers/HtmlEditorProviders/MyProvider/1.0.1</path>
                    </folder>
                    <folder>
                        <path>Providers/HtmlEditorProviders/MyProvider/1.0.2</path>
                    </folder>
                    ...
                </component>
            </components>
        </package>
    </packages>
</dotnetnuke>

The value of path is validated so that it can only reference valid paths inside the virtual directory.

[mitchelsellers]

I have a feeling we need to be more protective with this validation test as it would be very easy to corrupt an installation with this.

Values such as

• /DesktopModules
• /Portals/0
• /Bin

Or otherwise, and since this is a recursive delete, that doesn't expect folders to be empty I think we need to prevent at least our critical directories from being cleaned?

[daguiler]

Yes, good point, although critical files could still get deleted using the glob parameter.
Anyway, I have changed the original indiscriminate delete now with a new method that only deletes empty directories. This avoids the risk of any files being deleted by CleanupInstaller.

[valadas]

Awesome work, thanks!