Feature/eventlog ip address with proxy #5091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadas
approved these changes
Apr 20, 2022
tbh: me neither. Ran into the issue after putting a client behind Cloudflare and we got pointed out this issue. When trying to figure out how to fix that, I found that it was implemented already, for a large part. |
bdukes
reviewed
Apr 26, 2022
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
|
Thanks for your improvements, @bdukes |
mitchelsellers
approved these changes
Apr 28, 2022
bdukes
reviewed
Apr 28, 2022
bdukes
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5073
Summary
Changed the places where DNN didn't determine IPAddress by using the UserRequestIPAddressController class yet, to use that.
I found these occurences in: