-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/eventlog ip address with proxy #5091
Feature/eventlog ip address with proxy #5091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, I did know even know about that class!
tbh: me neither. Ran into the issue after putting a client behind Cloudflare and we got pointed out this issue. When trying to figure out how to fix that, I found that it was implemented already, for a large part. |
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Thanks for your improvements, @bdukes |
Closes #5073
Summary
Changed the places where DNN didn't determine IPAddress by using the UserRequestIPAddressController class yet, to use that.
I found these occurences in: