Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate moment to dayjs for Dnn.PersonaBar.UI #5107

Merged
merged 2 commits into from
May 2, 2022
Merged

Migrate moment to dayjs for Dnn.PersonaBar.UI #5107

merged 2 commits into from
May 2, 2022

Conversation

david-poindexter
Copy link
Contributor

Summary

  • Migrate moment to dayjs for Dnn.PersonaBar.UI.
  • Remove unused functions from util.js.
  • Remove dateTimePicker knockout components (koComponents).
  • Remove datePicker.js from knockout binding handlers (koBindingHandlers).
  • Update all .eslintskipwords.js to remove pikaday.
  • Remove pikaday from Dnn.PersonaBar.UI because it was ultimately never used. react-day-picker is used instead.
  • Update referenced license info to remove pikaday.

Resolves #3875

@david-poindexter david-poindexter added this to the 9.10.3 milestone May 1, 2022
@david-poindexter david-poindexter self-assigned this May 1, 2022
@david-poindexter david-poindexter mentioned this pull request May 1, 2022
Closed
18 tasks
valadas
valadas approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I can confirm that the removed things appear to not be used by anything and I downloaded this build and tried various date pickers in the persona bar modules, everything looks good to me.THanks!
🌮

@valadas valadas merged commit 5b9fca6 into dnnsoftware:develop May 2, 2022
@david-poindexter david-poindexter deleted the dayjs-pb-ui branch May 2, 2022 23:46
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@bdukes bdukes bdukes approved these changes

Assignees

@david-poindexter david-poindexter

Labels
Type: Enhancement
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.

Replace momentjs with dayjs
3 participants
@david-poindexter @bdukes @valadas