Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with undefined isProduction in Yarn scripts #5121

Merged
merged 1 commit into from
May 11, 2022

Conversation

donker
Copy link
Contributor

@donker donker commented May 11, 2022

Resolves issue #5120

What it does is to replace the following:

module.exports = {

with

module.exports = (env, argv) => {
  const isProduction = argv.mode === "production";
  return {

for all the webpack configurations where we use isProduction. The command line p option (i.e. webpack -p) will now properly set isProduction in the configuration.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice catch there.

@bdukes bdukes modified the milestones: 9.11.0, 9.10.3 May 11, 2022
@bdukes bdukes merged commit 3dadca3 into dnnsoftware:develop May 11, 2022
@david-poindexter
Copy link
Contributor

Thank you so much @donker 🙏🏼

@donker donker deleted the fix-yarn-local branch July 24, 2022 08:28
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants