Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Portable.BouncyCastle from 1.8.10 to 1.9.0 #5134

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 2, 2022

Bumps Portable.BouncyCastle from 1.8.10 to 1.9.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added .NET Pull requests that update .net code Type: Maintenance labels Jun 2, 2022
@bdukes bdukes force-pushed the dependabot/nuget/Portable.BouncyCastle-1.9.0 branch from e9df66d to 09d0748 Compare June 3, 2022 14:17
@bdukes bdukes added this to the 9.10.3 milestone Jun 3, 2022
@bdukes bdukes force-pushed the dependabot/nuget/Portable.BouncyCastle-1.9.0 branch from dd248a6 to 8a0d133 Compare July 25, 2022 22:18
dependabot bot and others added 2 commits July 26, 2022 09:16
Bumps [Portable.BouncyCastle](https://github.com/novotnyllc/bc-csharp)
from 1.8.10 to 1.9.0.
- [Release notes](https://github.com/novotnyllc/bc-csharp/releases)
-
[Commits](novotnyllc/bc-csharp@pcl-v1.8.10...pcl-v1.9.0)

---
updated-dependencies:
- dependency-name: Portable.BouncyCastle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Platform/Connectors/GoogleTagManager/Dnn.GoogleTagManagerConnector.csproj
Platform/DotNetNuke.Website.Deprecated/DotNetNuke.Website.Deprecated.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/DotNetNuke.Authentication.Facebook.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/web.Debug.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/web.Release.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/web.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/DotNetNuke.Authentication.Google.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/web.Debug.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/web.Release.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/web.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/DotNetNuke.Authentication.LiveConnect.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/web.Debug.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/web.Release.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/web.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/DotNetNuke.Authentication.Twitter.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/web.Debug.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/web.Release.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/web.config
Platform/Providers/CachingProviders/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider.csproj
Platform/Providers/CachingProviders/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider/app.config
Platform/Providers/ClientCapabilityProviders/Provider.AspNetCCP/DotNetNuke.Providers.AspNetCCP.csproj
Platform/Providers/ClientCapabilityProviders/Provider.AspNetCCP/app.config
Platform/Tests/DNN.Integration.Test.Framework/DNN.Integration.Test.Framework.csproj
Platform/Tests/DotNetNuke.Tests.Authentication/DotNetNuke.Tests.Authentication.csproj
Platform/Tests/DotNetNuke.Tests.Utilities/DotNetNuke.Tests.Utilities.csproj
Dnn.AdminExperience/EditBar/Dnn.EditBar.Library/Dnn.EditBar.Library.csproj
@bdukes bdukes force-pushed the dependabot/nuget/Portable.BouncyCastle-1.9.0 branch from 8a0d133 to 06b9314 Compare July 26, 2022 14:17
@bdukes bdukes merged commit 3ff21a4 into develop Jul 26, 2022
@dependabot dependabot bot deleted the dependabot/nuget/Portable.BouncyCastle-1.9.0 branch July 26, 2022 16:01
@dimarobert
Copy link
Contributor

dimarobert commented Aug 4, 2022

@bdukes Version in the manifest was not updated: https://github.com/dnnsoftware/Dnn.Platform/blob/develop/DNN%20Platform/Components/MailKit/MailKit.dnn#L33

Also, there is this commit which says that it was downgraded to 1.8.8 due to MailKit (from 1.8.9). Is that still valid?
9fd6fb1

Also also, the version on the MailKit.dnn manifest is wrong (1.8.10.1).

@bdukes
Copy link
Contributor

bdukes commented Aug 4, 2022

The versions are updated by the build process automatically. If we want to update them manually as well, that's fine, but not required.

We're currently referencing MimeKit 2.15.1 (from MailKit 2.15.0), which has a dependency on Portable.BouncyCastle (>= 1.8.10). We'll need to make sure and test that we didn't introduce an issue.

@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Pull requests that update .net code Type: Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants