Update Upgrade Process to remove Telerik (Continued from #5099)

[armaganpekatik]

Summary

Please see #5099

[mitchelsellers]

Module installation should be done via traditional module installation processes, not via a hard-coded installation using the 09.11.00.SqlDataProvider file as the module should not be installed in all situations. See below testing scenarios.

[mitchelsellers]

Suggested Testing Scenarios

• Upgrade Using UpgradeWizard - Prior version of DNN with NO Telerik

Should upgrade, no notice/warning be provided, TelerikRemoval tool should not be installed, however, under Available Extensions, it should show as an item that can be installed

• Upgrade Using Install.aspx - Prior Version of DNN with NO Telerik

Should upgrade, no notice/warning be provided, TelerikRemoval tool should not be installed, however under Available Extensions it should show as an item that can be installed

• Upgrade Using Upgrade Wizard - Prior version of DNN w/ Telerik - But Not Used - User Accepted Removal

Upgrade wizard should prompt for safe removal, if I select to Remove. After upgrade, Telerik should be removed, and upon completion, no instance of the TelerikRemoval module should be found.

• Upgrade Using Upgrade Wizard - Prior version of DNN w/ Telerik - But Not Used - User Declined Removal

Upgrade wizard should prompt for safe removal. If I select to NOT remove, Upgrade should not remove Telerik, or make any other changes for Telerik. TelerikRemoval module should be in the 'Available Modules' listing.

• Upgrade Using Install.aspx - Prior Version of DNN w/ Telerik - But Not Used

No changes to Telerik on upgrade, Upgrade log should note "Security Notice" about the removal of telerik.. TelerikRemoval module should be in the 'Available Modules' listing

Suggested Message - "Telerik was found in this installation, it does not appear to be used. We suggest using the Telerik Removal module to remove Telerik for security purposes"

• Upgrade Using Upgrade Wizard - Prior Version of DNN w/ Terik - Telerik In Use

Upgrade should prompt the user notified of the security warning. Upgrade will not change anything related to Teleri. TelerikRemoval module should be in the 'Available Modules' listing

• Upgrade Using Install.aspx - Prior Version of DNN w/ Telerik - Telerik In Use

No changes to Telerik on upgrade, Upgrade log should note "Security Notice" about the removal of telerik with a secondary note that it is in use by other components.. TelerikRemoval module should be in the 'Available Modules' listing

• Post Upgrade - User Installs Telerik Removal Module - Adds to Page - Telerik In Use

Module show that Telerik is in use and cannot be removed.

• Post Upgrade - User Installs Telerik Removal Module - Adds to Page - Telerik Not in Use

Module should show backup warning, then allow user to remove. Upon removal, module should be installed.

For Testing Purposes, you can install the DNN FAQ module as it has a Telerik Dependency.

[donker]

Closing this and continuing in PR #5212