-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DigitalAssets
with Resource Manager
in templates and remove DigitalAssets
module
#5194
Replace DigitalAssets
with Resource Manager
in templates and remove DigitalAssets
module
#5194
Conversation
DigitalAssets
with Resource Manager
in templates and remove DigitalAssets
module
Question - Should digital assets live on in a separate repo? (I don't believe so, but just asking) |
I don't think so either, we should not maintain a Telerik-based solution IMO and if someone really really wants to, they can grab it from the git history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks guys!
Strange the build failed creating nuget packages but the artifact is fine, I'll try to re-fire the build |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I believe the problem is in the bundle: |
That makes sense, why do include the DAM in there? I think we could simply remove it from the nuspec file right ? |
Yeah, I think so. I'll test that now. |
Okay, this PR is ready for a second review. CC @dnnsoftware/approvers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you!
Summary
Resolves #4895
Blank Website
template to replaceDigital Assets
module withResource Manager
Default Website
template to replaceDigital Assets
module withResource Manager
admin
template (though this is not used in the UI) to replaceDigital Assets
module withResource Manager
DigitalAssets
module