Replace DigitalAssets with Resource Manager in templates and remove DigitalAssets module
#5194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-poindexter
changed the title
DigitalAssets with Resource Manager in templates and remove DigitalAssets module
|
Question - Should digital assets live on in a separate repo? (I don't believe so, but just asking) |
|
I don't think so either, we should not maintain a Telerik-based solution IMO and if someone really really wants to, they can grab it from the git history. |
valadas
approved these changes
Jul 21, 2022
|
Strange the build failed creating nuget packages but the artifact is fine, I'll try to re-fire the build |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I believe the problem is in the bundle: |
That makes sense, why do include the DAM in there? I think we could simply remove it from the nuspec file right ? |
|
Yeah, I think so. I'll test that now. |
|
Okay, this PR is ready for a second review. CC @dnnsoftware/approvers |
mitchelsellers
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #4895
Blank Websitetemplate to replaceDigital Assetsmodule withResource ManagerDefault Websitetemplate to replaceDigital Assetsmodule withResource Manageradmintemplate (though this is not used in the UI) to replaceDigital Assetsmodule withResource ManagerDigitalAssetsmodule