Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Client Resources Manager for CKEditor Provider dialogs #5205

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jul 27, 2022

For #5114

This PR adds Client Resource Manager support in the Browser.aspx and Options.aspx dialogs used by the CKEditor Provider and adjusts the JS and CSS of those dialogs to be loaded via the CRM.

I also adjusted the build script to resolve issues with builds not updating the website.

Finally, I made a couple of localization related changes, changing "Browser-Modus" to "Browser Mode" in the default resx file and extracting a common localization function.

@bdukes bdukes added this to the 9.10.3 milestone Jul 27, 2022
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@donker donker merged commit a6aac6d into dnnsoftware:develop Jul 28, 2022
@bdukes bdukes deleted the client-resources-ckeditor branch August 2, 2022 16:19
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants