Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNN-7273 Added js function to handle error messages from a service an… #906

Merged
merged 2 commits into from
Oct 19, 2015

Conversation

pberna
Copy link
Contributor

@pberna pberna commented Oct 19, 2015

…d show them in the UI. Fix checking of existing content types and content fields: now it is case insensitive. Also changed HTTP status code returned when the entity is not valid: from 500 (Internal Server Error) to 422 (Unprocessable entity)

…d show them in the UI. Fix checking of existing content types and content fields: now it is case insensitive. Also changed HTTP status code returned when the entity is not valid: from 500 (Internal Server Error) to 422 (Unprocessable entity)
@francescorivola
Copy link
Contributor

hi @ohine, correct. This is a pending change. We plan to change DCC Web Methods soon and use some Exception Filter Attribute so any unhandled exception is properly logged in the Event Viewer (right now it does not) and return only a friendly message (for UI perspective) or just the http status code as part http response. As you said we should never expose server side detail to the client.

@francescorivola francescorivola added this to the 8.0.0 milestone Oct 19, 2015
@francescorivola francescorivola self-assigned this Oct 19, 2015
francescorivola added a commit that referenced this pull request Oct 19, 2015
DNN-7273 Added js function to handle error messages from a service an…
@francescorivola francescorivola merged commit 71874d0 into development Oct 19, 2015
@francescorivola francescorivola deleted the bug/DNN-7273 branch October 19, 2015 15:26
@jbrinkman jbrinkman added nop and removed nop labels Nov 3, 2015
valadas pushed a commit to valadas/Dnn.Platform that referenced this pull request Oct 2, 2019
Add "remove deleted users" button to place you'd expect it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants