SCM-762 #101

mean2me · 2017-10-20T09:52:56Z

No description provided.

* added react-dom to "externals" in webpack.config.js * removed from repository a unused bundle file * added a missing dev dependency (eslint-config-dnn)

…ed for prepublishOnly

…common component

…pack dependency for SvgIcons common component

…pack dependency for Checkbox common component

…pack dependency for Collapsible common component

…pack dependency for CollapsibleRow common component

…pack dependency for ContentLoaderWrapper common component

…pack dependency for DatePicker common component

…pack dependency for DayPicker common component

…pack dependency for DatePicker common component

…pack dependency for Dropdown common component

…pack dependency for DropdownWithError common component

…pack dependency for Droppable common component

…pack dependency for EditableField common component

…pack dependency for FileUpload common component

…pack dependency for FolderPicker common component

…pack dependency for GridCell common component

…pack dependency for GridSystem common component

…pack dependency for InputGroup common component

…pack dependency for Modal common component

…pack dependency for MultilineInput common component

…pack dependency for MultiLineInputWithError common component

DNN-10066 Fixed bundle's size issue. From 260kb to 52kb.

CONTENT-7612: localize dnn-file-upload component.

…G files management.

DNN-10414: provided option to make current page not selectable

…CM-762-merge # Conflicts: # Collapsible/lib/Collapsible.js # FileUpload/lib/FileUpload.js # FileUpload/package.json # InputGroup/lib/InputGroup.js # InputGroup/package.json # PagePicker/lib/PagePicker.js # PagePicker/package.json # PersonaBarPageHeader/lib/PersonaBarPageHeader.js # PersonaBarPageHeader/package.json # PersonaBarPageHeader/webpack.config.js # SvgIcons/lib/SvgIcons.js # SvgIcons/package.json # SvgIcons/src/SvgIcons.jsx # TextOverflowWrapper/package.json # TextOverflowWrapper/webpack.config.js # TextOverflowWrapperNew/lib/TextOverflowWrapperNew.js # TextOverflowWrapperNew/package.json # Tooltip/lib/Tooltip.js

tpluscode · 2017-11-01T08:32:48Z

.gitignore

+node_modules
+/sinopiautil.js


Using rlidwka/sinopia? It looks kind of dead (rlidwka/sinopia#463 rlidwka/sinopia#376)

tpluscode · 2017-11-01T08:41:48Z

Collapsible/.babelrc

@@ -0,0 +1,6 @@
+{


How come the components before this one (alphabetically) didn't have a .babelrc?

tpluscode · 2017-11-01T08:49:23Z

DayPicker/package.json

+    "react": "^15.3.2",
+    "react-day-picker": "^2.3.3",
+    "moment": "2.13.0",
+    "raw-loader": "0.5.1",


You removed !raw! in jsx so maybe this dependency is no longer needed?

tpluscode · 2017-11-01T09:12:15Z

FileUpload/package.json

-    "url-loader": "0.5.7",
-    "webpack": "1.13.0"
+    "react": "^15.6.2",
+    "react-custom-scrollbars": "^4.1.2",


Hm, are we using more than one solution for scrollbars?

yes, I also found different scrollbars' libraries in other projects.

tpluscode · 2017-11-01T09:12:47Z

FileUpload/src/FileUpload.jsx

-            fileInput.value = '';
+    clearFileUploaderValue(fileInput) {
+        if (fileInput) {
+            fileInput.value = "";


I though single quotes were the default ;)

project standard seems to be double quotes :)

tpluscode · 2017-11-01T09:22:45Z

PersonaBarPageBody/package.json

+    "react": "^15.3.2",
+    "dnn-global-styles": "0.0.5",
+    "dnn-grid-cell": "0.0.4",
+    "dnn-back-to-link": "0.0.3"


How cute. These dnn components weren't even included in old dependencies :D

I had to check deps one by one... it happened in many other places and made testing and debugging quite hard before.

tpluscode · 2017-11-01T09:23:32Z

PersonaBarPageHeader/package.json

@@ -1,37 +1,49 @@
 {
  "name": "dnn-persona-bar-page-header",
-  "version": "0.0.29",
+  "version": "0.0.31",


I keep looking at those versions and I'm getting the impression that we're not really using server correctly?

tpluscode · 2017-11-01T09:28:55Z

package.json

@@ -17,6 +17,7 @@
    "babel-loader": "6.2.4",
    "babel-preset-es2015": "6.6.0",
    "babel-preset-react": "6.5.0",
+    "cpy": "^6.0.0",
    "css-loader": "0.23.1",


Why is this file even here, in root? And package name is dnn-tree-control?

maybe some wild cut and paste :)

tpluscode · 2017-11-01T09:30:14Z

TreeControlInteractor/package.json

-    "dnn-text-overflow-wrapper-new": "0.0.4",
-    "shortid": "^2.2.8"
+    "shortid": "^2.2.8",
+    "lodash": "4.17.4",


Are we doing tree shaking in end apps? If not maybe we could import the individual features of lodash?

tpluscode · 2017-11-01T09:33:14Z

FileUpload/src/Browse/FilePicker.jsx

@@ -4,8 +4,6 @@ const searchIcon = require("!raw!./img/search.svg");
 const fileIcon = require("!raw!./img/pages.svg");
 import { Scrollbars } from "react-custom-scrollbars";

-const notSpecifiedText = "<None Specified>";


Out of curiosity, where is the default text now?

Actually the real problem here is the "!raw!" prefix... I should investigate, since it won't work without webpack, I guess.

tpluscode · 2017-11-01T09:33:48Z

FileUpload/src/FileUpload.jsx

@@ -67,7 +64,7 @@ export default class FileUpload extends Component {
        }
        if (nextProps.selectedFile.fileId !== this.state.selectedFile.fileId) {
            const file = nextProps.selectedFile;
-            this.updateFileState(file);
+            //this.updateFileState(file);


Not needed anymore? Please consider removing

I don't know who and why made this. This pull requests focus on project structure and build process.

tpluscode · 2017-11-01T09:38:13Z

InputGroup/src/style.less

        border-collapse: separate;
        width: 100%;
+        float: left;


Are you sure float isn't going to cause trouble?

I don't know about the code of each components. It's part of our next issues when we will decide how to manage common components

I mean, this looks like a new style prop here. I worry it could break some UI

tpluscode · 2017-11-01T09:44:08Z

TextOverflowWrapper/src/TextOverflowWrapper.jsx

-        });
+    componentDidMount() {
+        //Set time out to ensure calculation happens after render
+        setTimeout(() => {


Is setTimeout the best option to synchronise?

Maybe not. I don't know who and why made this. This pull requests focus on project structure and build process.

emac80 added 30 commits October 16, 2017 19:27

DNN-10066 Fixed bundle's size issue. From 260kb to 52kb.

a471565

* added react-dom to "externals" in webpack.config.js * removed from repository a unused bundle file * added a missing dev dependency (eslint-config-dnn)

SCM-762 Source map generation from babel, new compilation scripts add…

5e5ba3c

…ed for prepublishOnly

SCM-762 removed unused dependencies (webpack included)

42563e6

SCM-762 Dependencies review for eslint-config-dnn

6e122f4

SCM-762 eslint config, babel config, dependencies review

bd59b44

SCM-762 eslint shared configuration review, dependencies review

4fb13a6

SCM-762 eslint, sourcemap, webpack removal, dependencies optimization

5d7ea2f

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies for Tooltip …

130c49c

…common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

a13ce75

…pack dependency for SvgIcons common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

3242faf

…pack dependency for Checkbox common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

a84fa21

…pack dependency for Collapsible common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

41ad7cf

…pack dependency for CollapsibleRow common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

b673999

…pack dependency for ContentLoaderWrapper common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

f28e8e4

…pack dependency for DatePicker common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

425515b

…pack dependency for DayPicker common component

SCM-762 missing .babelrc and .eslintrc

e627e2f

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

f89d8ac

…pack dependency for DatePicker common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

4626875

…pack dependency for Dropdown common component

SCM-762 Review deps

85e65b1

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

bfee597

…pack dependency for DropdownWithError common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

74f1963

…pack dependency for Droppable common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

e25f075

…pack dependency for EditableField common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

9c1e4ef

…pack dependency for FileUpload common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

2cf743c

…pack dependency for FolderPicker common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

5288056

…pack dependency for GridCell common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

22875d2

…pack dependency for GridSystem common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

7af2630

…pack dependency for InputGroup common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

5504126

…pack dependency for Modal common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

099d8a8

…pack dependency for MultilineInput common component

SCM-762 Review of Babel, Sourcemap, Eslint, Dependencies, removed Web…

0f35e1f

…pack dependency for MultiLineInputWithError common component

emac80 and others added 20 commits October 20, 2017 12:28

SCM-762 version number review

56e44fb

DNN-10066 Upgrade version number

3db01f7

DNN-10066 Upgrade version number

9ffd3eb

DNN-10066 Version number upgrade

819df59

Merge pull request #98 from dnnsoftware/bug/DNN-10066

57efcfe

DNN-10066 Fixed bundle's size issue. From 260kb to 52kb.

SCM-762 Review version number

0f266ae

SCM-762 Review version number

fd42896

SCM-762 / SCM-1073 dev dependencies review

5832c85

DNN-9821: Updated the current published version on git

9e94bc3

DNN-9821: Rollback package.json as well

7e786f2

CONTENT-7612: changes after review.

20f8a1e

Merge pull request #100 from dnnsoftware/bug/CONTENT-7612

1149169

CONTENT-7612: localize dnn-file-upload component.

SCM-762 Review SvgIcons settings. Webpack reintroduced to optimize SV…

d566e4c

…G files management.

SCM-762 Dependencies massive review after one by one test.

a31cc71

SCM-762 dependencies' upgrade and review

9f0c27b

SCM-762 Final massive review of package.json dependencies

5d67534

SCM-762 Fix webpack issue after testing on SC

4f31386

SCM-762 ignore the generated lib folder by "preprocessOnly" script

9aa8221

DNN-10414: provided option to make current page not selectable

052b6de

Merge pull request #104 from dnnsoftware/bug/DNN-10414

9303eac

DNN-10414: provided option to make current page not selectable

mean2me added the Review in Progress label Oct 31, 2017

tpluscode reviewed Nov 1, 2017

View reviewed changes

tpluscode removed the Review in Progress label Nov 2, 2017

tpluscode merged commit 85b3edc into master Nov 2, 2017

tpluscode deleted the task/SCM-762 branch November 2, 2017 11:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SCM-762 #101

SCM-762 #101

mean2me commented Oct 20, 2017

tpluscode Nov 1, 2017

tpluscode Nov 1, 2017

tpluscode Nov 1, 2017

tpluscode Nov 1, 2017

mean2me Nov 1, 2017

tpluscode Nov 1, 2017

mean2me Nov 1, 2017

tpluscode Nov 1, 2017

mean2me Nov 1, 2017

tpluscode Nov 1, 2017

tpluscode Nov 1, 2017

mean2me Nov 1, 2017

tpluscode Nov 1, 2017

tpluscode Nov 1, 2017

mean2me Nov 1, 2017

tpluscode Nov 1, 2017

mean2me Nov 1, 2017

tpluscode Nov 1, 2017

mean2me Nov 1, 2017

tpluscode Nov 1, 2017 •

edited

Loading

tpluscode Nov 1, 2017

mean2me Nov 1, 2017

		node_modules
		/sinopiautil.js

SCM-762 #101

SCM-762 #101

Conversation

mean2me commented Oct 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tpluscode Nov 1, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tpluscode Nov 1, 2017 •

edited

Loading