This repository has been archived by the owner on May 7, 2019. It is now read-only.
Issue upgrade npm #153
Merged
Issue upgrade npm #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 17, 2018 09:22
…et Spellchecker identifier to false to prevent excessive warnings that are invalid.
…m a earlier commit mistake. All components should be under a sub-folder.
…findDOMNode errors0
added 17 commits
October 2, 2018 10:26
|
|
donker
approved these changes
Nov 4, 2018
ohine
approved these changes
Nov 4, 2018
There was a problem hiding this comment.
I agree with @donker on this one. Currently we can't even build this project in VSTS due to the duplication of dependent packages. Merging this so we can then start to restructure things and clean up the build process. We don't want to introduce any conflicts with the two efforts stepping on each other.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this was to upgrade all the npm packages. There were several issues during this revolving around the use of the findDOMNode function. This is a "last resort" function and the linter will not allow you to build when the component uses it. I have updated those offending components by using the updated React.createRef().
I also changed the package references for local packages. For example, if the TransitionModal component used the Tooltip component TransitionModal was pulling the component from MyGet instead of referencing it locally. I changed those references to use File:../ refs. This should also fix a build issue where you would have to build more than once just to get a local component update.
Before building a npm install or yarn install should be performed and then the prepublishOnly script tasks should be run.
This is quite a large pull request. This project structure needs some work but I will create another issue and do another pull request so we can publish a single package to npm / myget and then just use the components we would like.