Skip to content
This repository has been archived by the owner on May 7, 2019. It is now read-only.

Makes the tooltips accessible #212

Merged
merged 12 commits into from
Jan 24, 2019

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Jan 22, 2019

We are still having issues with the tooltips at multiple places even after we tought the last fix worked, it just changed which tooltips are affected.

This is an alternate solution and replaces the tooltip by an accessible component.

  • It fixes the issue
  • It is accessible (tab to the icon to show and read the tooltip, has aria attributes too)
  • It does not support (out of the box) delayHide, but delayHide is not used by any platform module on that component and I have cofirmed with @daguiler that it is the same case on evoq, so it should not be a problem.

Closes #211

@valadas valadas added this to the 9.3.0 milestone Jan 22, 2019
@valadas valadas changed the title Alternate fix for the tooltips issue Makes the tooltips accessible Jan 23, 2019
Copy link
Contributor

@daguiler daguiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine when applied to latest build. Did a quick test on Evoq as well and I don't see any side effects.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants