Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternative DNS resolver for initial setup #25

Merged
merged 12 commits into from
Jan 18, 2024

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2023

Use custom DNS resolver for HTTP requests to the DNSimple API during the initial setup phase to ensure they don't fail if the CoreDNS server itself is used as the system resolver, as it won't be ready at that time. Fixes #21

@ghost ghost self-requested a review August 10, 2023 11:43
setup.go Outdated Show resolved Hide resolved
@ghost ghost requested a review from DXTimer October 24, 2023 06:27
@DXTimer DXTimer self-assigned this Dec 19, 2023
@weppos weppos changed the title Use alternative DNS resolver for initial setup (fixes #21) Use alternative DNS resolver for initial setup Jan 18, 2024
@weppos weppos added the enhancement New feature, enhancement or code changes, not related to defects label Jan 18, 2024
@weppos
Copy link
Member

weppos commented Jan 18, 2024

Planned to be completed by next week.

@DXTimer DXTimer merged commit f953deb into main Jan 18, 2024
3 checks passed
@DXTimer DXTimer deleted the enhancement/use-alt-dns-resolver-for-init branch January 18, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, enhancement or code changes, not related to defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide workaround for self-bootstrapping
3 participants