Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send status updates after each fetch #6

Merged
12 commits merged into from
Jul 4, 2023
Merged

Send status updates after each fetch #6

12 commits merged into from
Jul 4, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 23, 2023

This sends a status update on every fetch.

@ghost ghost added the enhancement New feature, enhancement or code changes, not related to defects label Jun 23, 2023
@ghost ghost requested review from DXTimer and AGS4NO June 23, 2023 11:33
@ghost ghost self-assigned this Jun 23, 2023
@DXTimer
Copy link
Contributor

DXTimer commented Jun 26, 2023

@wilson-dnsimple The field has been added and is up for review https://github.com/dnsimple/dnsimple-app/pull/23081.

@ghost ghost marked this pull request as ready for review June 28, 2023 05:53
dnsimple.go Outdated Show resolved Hide resolved
dnsimple.go Outdated Show resolved Hide resolved
dnsimple.go Outdated Show resolved Hide resolved
dnsimple.go Outdated Show resolved Hide resolved
dnsimple.go Outdated Show resolved Hide resolved
Wilson Lin and others added 4 commits July 3, 2023 18:06
Co-authored-by: Ivan Bakalov <ibbakalov@gmail.com>
Co-authored-by: Ivan Bakalov <ibbakalov@gmail.com>
@ghost ghost requested a review from DXTimer July 3, 2023 08:35
@DXTimer
Copy link
Contributor

DXTimer commented Jul 3, 2023

@wilson-dnsimple there are unresolved conflicts with main.

Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the conflicts are merged this is ready to go.

@ghost ghost merged commit 9a8a605 into main Jul 4, 2023
3 checks passed
@ghost ghost deleted the feature/status-updates branch July 4, 2023 10:30
DXTimer pushed a commit that referenced this pull request Jul 12, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, enhancement or code changes, not related to defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant