-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send status updates after each fetch #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
enhancement
New feature, enhancement or code changes, not related to defects
label
Jun 23, 2023
ghost
self-assigned this
Jun 23, 2023
@wilson-dnsimple The field has been added and is up for review https://github.com/dnsimple/dnsimple-app/pull/23081. |
ghost
marked this pull request as ready for review
June 28, 2023 05:53
DXTimer
reviewed
Jun 28, 2023
DXTimer
reviewed
Jun 28, 2023
Co-authored-by: Ivan Bakalov <ibbakalov@gmail.com>
Co-authored-by: Ivan Bakalov <ibbakalov@gmail.com>
ghost
requested a review
from DXTimer
July 3, 2023 08:35
@wilson-dnsimple there are unresolved conflicts with main. |
DXTimer
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the conflicts are merged this is ready to go.
ghost
deleted the
feature/status-updates
branch
July 4, 2023 10:30
DXTimer
pushed a commit
that referenced
this pull request
Jul 12, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends a status update on every fetch.