Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain restore methods #379

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Add domain restore methods #379

merged 2 commits into from
Feb 29, 2024

Conversation

kntsoriano
Copy link
Contributor

Belongs to https://github.com/dnsimple/dnsimple-business/issues/1654.

Description

This adds two methods to the library: (1) RestoreDomain and (2) GetDomainRestore. The API endpoint implementation is in https://github.com/dnsimple/dnsimple-app/pull/25863.

@kntsoriano kntsoriano requested a review from a team February 22, 2024 06:52
@kntsoriano kntsoriano self-assigned this Feb 22, 2024
Copy link
Contributor

@ggalmazor ggalmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# client.registrar.restore_domain(1010, "example.com", {})
#
# @param [Integer] account_id the account ID
# @param [#to_s] domain_name the domain name to renew
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @param [#to_s] domain_name the domain name to renew
# @param [#to_s] domain_name the domain name to restore

@kntsoriano kntsoriano merged commit 3cd674c into main Feb 29, 2024
9 checks passed
@kntsoriano kntsoriano deleted the domain-restore-endpoints branch February 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants