Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add active attribute in EmailForward struct #400

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add active attribute in EmailForward struct #400

merged 2 commits into from
Nov 22, 2024

Conversation

ggalmazor
Copy link
Contributor

@ggalmazor ggalmazor commented Nov 20, 2024 •
edited
Loading

Fixes #399

This PR adds the new active attribute in the EmailForward struct to expose its value from DNSimple API's responses.

@ggalmazor ggalmazor requested a review from kojdm November 20, 2024 09:42
@ggalmazor ggalmazor self-assigned this Nov 20, 2024
@ggalmazor ggalmazor merged commit 34ab4d9 into main Nov 22, 2024
8 checks passed
@ggalmazor ggalmazor deleted the update_email_forward_fields branch November 22, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojdm kojdm kojdm approved these changes

Assignees

@ggalmazor ggalmazor

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt client to deal with new active attribute in email forward structures
2 participants
@ggalmazor @kojdm