Actually check dependencies in CI #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
changed the title
This was referenced Nov 2, 2024
|
@whatyouhide just to understand, the PR contains an update for all dependencies, or one PR for dependency? |
|
@weppos all dependencies. Doing one PR per dependency would be significantly harder implementation wise, and since we have to implement this ourselves I’m leaning on the simpler solution. Thoughts? |
Sounds good for now. The risk of updating all deps at once is that it may be harder to deal with deps with large changes. But hopefully this should be less of an issue if we update them more consistently than what we did in the past. |
weppos
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates PRs like #169 (that one has changes from this branch too but you get the idea).