refactor: 🎨 support undefined modelValue #895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-dsfr-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ArnaudTA
force-pushed
the
refactor/select-undefined-value
branch
5 times, most recently
from
359bba8
to
d540cc9
Compare
ArnaudTA
force-pushed
the
refactor/select-undefined-value
branch
from
d540cc9
to
f8b8dfd
Compare
laruiss
reviewed
Aug 22, 2024
Comment on lines
-7
to
+8
| modelValue?: string | number | ||
| modelValue?: string |
| @@ -1,12 +1,13 @@ | |||
| export type DsfrSelectOption = string | { value: string, text: string, disabled?: boolean } | |||
There was a problem hiding this comment.
Pourquoi il n’y a plus undefined ?
| value="" | ||
| :selected="modelValue == null" | ||
| :value="undefined" | ||
| :selected="typeof modelValue === 'undefined'" |
There was a problem hiding this comment.
Pourquoi seulement si modelValue est undefined ? (actuellement, c’est si modelValue est nullish)
Comment on lines
-85
to
+84
| :selected="modelValue === option || (typeof option === 'object' && option.value === modelValue)" | ||
| :selected="(typeof option === 'object' && option.value === modelValue) || modelValue === option" |
There was a problem hiding this comment.
Qu’apporte ce changement ?
laruiss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.