Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DsfrRadioButtonSet): ✨ permet d’ajouter un hint via une props ou… #916

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

iNeoO
Copy link
Collaborator

@iNeoO iNeoO commented Sep 3, 2024

… un slot

#899

image

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for vue-dsfr-demo ready!

Name Link
🔨 Latest commit 6139fc2
🔍 Latest deploy log https://app.netlify.com/sites/vue-dsfr-demo/deploys/66d71868d1dd5d0008d33562
😎 Deploy Preview https://deploy-preview-916--vue-dsfr-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

:id="titleId"
class="fr-fieldset__legend fr-fieldset__legend--regular"
>
<!-- @slot Slot pour personnaliser tout le contenu de la balise <legend> cf. [DsfrInput](/?path=/story/composants-champ-de-saisie-champ-simple-dsfrinput--champ-avec-label-personnalise). Une **props porte le même nom pour une légende simple** (texte sans mise en forme) -->
<slot name="legend">
{{ legend }}
<span class="fr-hint-text">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Par contre je ne sais pas s'il vaut mieux que le hint wrap ou soit wrap par le <span class="fr-hint-text">

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C’est bien comme ça, il faudrait rajouter un v-if="hind || $slot.hint" sur ce span pour qu’il ne soit pas dans le DOM s’il est vide

:id="titleId"
class="fr-fieldset__legend fr-fieldset__legend--regular"
>
<!-- @slot Slot pour personnaliser tout le contenu de la balise <legend> cf. [DsfrInput](/?path=/story/composants-champ-de-saisie-champ-simple-dsfrinput--champ-avec-label-personnalise). Une **props porte le même nom pour une légende simple** (texte sans mise en forme) -->
<slot name="legend">
{{ legend }}
<span class="fr-hint-text">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C’est bien comme ça, il faudrait rajouter un v-if="hind || $slot.hint" sur ce span pour qu’il ne soit pas dans le DOM s’il est vide

@laruiss laruiss changed the base branch from main to develop September 4, 2024 15:58
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for vue-dsfr ready!

Name Link
🔨 Latest commit 2a4d818
🔍 Latest deploy log https://app.netlify.com/sites/vue-dsfr/deploys/66d88431ec74000008671c20
😎 Deploy Preview https://deploy-preview-916--vue-dsfr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for docs-vue-dsfr ready!

Name Link
🔨 Latest commit 505192b
🔍 Latest deploy log https://app.netlify.com/sites/docs-vue-dsfr/deploys/66d884ca4fe9050008f3a007
😎 Deploy Preview https://deploy-preview-916--docs-vue-dsfr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for demo-vue-dsfr ready!

Name Link
🔨 Latest commit 505192b
🔍 Latest deploy log https://app.netlify.com/sites/demo-vue-dsfr/deploys/66d884ca20a8ad00088d6116
😎 Deploy Preview https://deploy-preview-916--demo-vue-dsfr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for vue-dsfr ready!

Name Link
🔨 Latest commit 505192b
🔍 Latest deploy log https://app.netlify.com/sites/vue-dsfr/deploys/66d884cab6ac500008a8b572
😎 Deploy Preview https://deploy-preview-916--vue-dsfr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@laruiss laruiss merged commit acdd5e4 into develop Sep 4, 2024
12 of 13 checks passed
@laruiss laruiss deleted the feat/899 branch September 4, 2024 16:08
Copy link

github-actions bot commented Sep 4, 2024

🎉 This issue has been resolved in version 5.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants