-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DsfrRadioButtonSet): ✨ permet d’ajouter un hint via une props ou… #916
Conversation
✅ Deploy Preview for vue-dsfr-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
:id="titleId" | ||
class="fr-fieldset__legend fr-fieldset__legend--regular" | ||
> | ||
<!-- @slot Slot pour personnaliser tout le contenu de la balise <legend> cf. [DsfrInput](/?path=/story/composants-champ-de-saisie-champ-simple-dsfrinput--champ-avec-label-personnalise). Une **props porte le même nom pour une légende simple** (texte sans mise en forme) --> | ||
<slot name="legend"> | ||
{{ legend }} | ||
<span class="fr-hint-text"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Par contre je ne sais pas s'il vaut mieux que le hint wrap ou soit wrap par le <span class="fr-hint-text">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C’est bien comme ça, il faudrait rajouter un v-if="hind || $slot.hint"
sur ce span pour qu’il ne soit pas dans le DOM s’il est vide
:id="titleId" | ||
class="fr-fieldset__legend fr-fieldset__legend--regular" | ||
> | ||
<!-- @slot Slot pour personnaliser tout le contenu de la balise <legend> cf. [DsfrInput](/?path=/story/composants-champ-de-saisie-champ-simple-dsfrinput--champ-avec-label-personnalise). Une **props porte le même nom pour une légende simple** (texte sans mise en forme) --> | ||
<slot name="legend"> | ||
{{ legend }} | ||
<span class="fr-hint-text"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C’est bien comme ça, il faudrait rajouter un v-if="hind || $slot.hint"
sur ce span pour qu’il ne soit pas dans le DOM s’il est vide
✅ Deploy Preview for vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for demo-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🎉 This issue has been resolved in version 5.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
… un slot
#899