fix: đ la fonction de tri par dĂ©faut sur le DsfrDataTable #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
đ· Deploy request for vue-dsfr pending review.Visit the deploys page to approve it
|
â Deploy Preview for docs-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
â Deploy Preview for demo-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
laruiss
requested changes
Oct 21, 2024
|
đ This issue has been resolved in version 7.0.2 đ The release is available on:
Your semantic-release bot đŠđ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello vue-dsfr,
Le tri ne fonctionne pas comme attendu sur le DsfrDataTable, en effet dans la mĂ©thode de tri par dĂ©faut câest toujours le
props.sortedqui sert pour dĂ©terminer quel clĂ© est utilisĂ©e. Câest plutĂŽtsortedBy.valuequi devrait ĂȘtre utilisĂ©.Jâajoute (non corrigĂ© ici) que le tri ne fonctionne pas pour les colonnes qui ont une
key(dans la dĂ©finition des colonnes) qui ne correspond pas Ă un attribut de lâobjet, et il est impossible dâavoir un tri fonctionnel sur ces colonnes actuellement.