Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19 remove orphaned cov argument from normallhs sampling #20

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ pyDOE3>=1.0
psutil>=5.9
hilbertcurve>=2.0.5

dictIO>=0.2.9
ospx>=0.2.11
dictIO>=0.3.1
ospx>=0.2.12

# ../dictIO
# ../ospx
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ install_requires =
pyDOE3>=1.0
psutil>=5.9
hilbertcurve>=2.0.5
dictIO>=0.2.9
ospx>=0.2.11
dictIO>=0.3.1
ospx>=0.2.12
# dictIO @ file:../dictIO
# ospx @ file:../ospx

Expand Down
9 changes: 3 additions & 6 deletions src/farn/sampling/sampling.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ def _set_up_known_sampling_types(self):
],
"optional_args": [
"_ranges",
"_cov",
],
},
"sobol": {
Expand Down Expand Up @@ -283,15 +282,13 @@ def _generate_samples_using_uniform_lhs_sampling(self) -> Dict[str, List[Any]]:
return samples

def _generate_samples_using_normal_lhs_sampling(self) -> Dict[str, List[Any]]:
"""LHS using gaussian normal distributions
"""LHS using gaussian normal distributions.

required input arguments:
* _names: required names template
* _numberOfSamples: required how many samples
* _mu: required absolute location vector of distribution center point (origin)
* _sigma: variation (vector), or required scalar, optional vector, optional cov
or
NOT IMPLEMENTED, DOES NOT MAKE MUCH SENSE!
* _cov: @ _mu optional rotation (tensor), otherwise I(_numberOfSamples,_numberOfSamples).
* _sigma: variation (vector), or required scalar, optional vector
"""
_ = self._check_length_matches_number_of_names("_mu")
if isinstance(self.sampling_parameters["_sigma"], Sequence):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_dicts/test_farnDict_normalLhs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test normalLhs
for sample set dimensioning
purpose:
generate a spacial, normal distributed sample set
_ranges: do not dimension the spacial extent of lhs, only limiting. for dimensioning _sigma (_cov) is used
_ranges: do not dimension the spatial extent of lhs, only limiting. For dimensioning, _sigma is used.
*/
_layers {
lhsvar
Expand Down