Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Baggins:GetRuleDesc() dead code? #24

Closed
toneomgomg opened this issue May 5, 2020 · 2 comments
Closed

Q: Baggins:GetRuleDesc() dead code? #24

toneomgomg opened this issue May 5, 2020 · 2 comments

Comments

@toneomgomg
Copy link
Contributor

function Baggins:GetRuleDesc(rule) seems to be dead code. It is never used anywhere from within Baggins.

Is it ever used from other addons? If not, that it should be factored out from Baggins-filtering.luaand all associated filter rules.

@doadin
Copy link
Owner

doadin commented May 5, 2020

Have not confirmed its use within baggins but of the four baggins plugings still showing up in curse/wowinterface it is never used. I think its safe to remove.

@toneomgomg
Copy link
Contributor Author

toneomgomg commented May 5, 2020 via email

doadin added a commit that referenced this issue May 5, 2020
@doadin doadin closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants