-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Q: Baggins:GetRuleDesc() dead code? #24
Comments
Have not confirmed its use within baggins but of the four baggins plugings still showing up in curse/wowinterface it is never used. I think its safe to remove. |
We could start with asserting a popup message in the function urging the
user to report back to you. That way we take out the guesswork, and don't
have to chance. By tagging the code in the cleanup, it will be a breeze to
bulk remove everything at a later date.
Den tis 5 maj 2020 21:33doadin <notifications@github.com> skrev:
… Have not confirmed its use within baggins but of the four baggins plugings
still showing up in curse/wowinterface it is never used. I think its safe
to remove.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUHFSHZC3ESHP5FIN3VGHDRQBSZVANCNFSM4MZRQFQA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
function Baggins:GetRuleDesc(rule)
seems to be dead code. It is never used anywhere from within Baggins.Is it ever used from other addons? If not, that it should be factored out from
Baggins-filtering.lua
and all associated filter rules.The text was updated successfully, but these errors were encountered: