Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While not validating models, still need a way to delete downloaded models that aren't valid #87

Closed
phildow opened this issue Jul 30, 2020 · 1 comment
Assignees

Comments

@phildow
Copy link
Contributor

phildow commented Jul 30, 2020

the model manager can only list model models that have loaded, and if the model.json is bad, the bundle won't load, so there will be invisible models sitting on the filesystem if the user downloaded them.

only necessary if a fix for #83 doesn't come quickly, since validation will prevent a model from ever hitting the filesystem

@phildow phildow self-assigned this Jul 30, 2020
@phildow
Copy link
Contributor Author

phildow commented Jul 30, 2020

For now just try to load the model bundle and consider that validation. Let the user know the problem is either with the packaging or the model.json file without more detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant