Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix hint on building docarray proto #711

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

samsja
Copy link
Member

@samsja samsja commented Oct 31, 2022

Context

fix a typo in the proto building hint

Signed-off-by: samsja 55492238+samsja@users.noreply.github.com

Signed-off-by: samsja <55492238+samsja@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #711 (4f0ee58) into main (92cc8b3) will decrease coverage by 2.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   88.10%   85.53%   -2.57%     
==========================================
  Files         133      133              
  Lines        6538     6538              
==========================================
- Hits         5760     5592     -168     
- Misses        778      946     +168     
Flag Coverage Δ
docarray 85.53% <ø> (-2.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/plot.py 28.13% <0.00%> (-39.83%) ⬇️
docarray/array/mixins/getattr.py 60.60% <0.00%> (-21.22%) ⬇️
docarray/array/queryset/parser.py 68.33% <0.00%> (-20.00%) ⬇️
docarray/array/mixins/io/csv.py 71.05% <0.00%> (-18.43%) ⬇️
docarray/array/mixins/setitem.py 64.16% <0.00%> (-18.34%) ⬇️
docarray/array/mixins/delitem.py 75.55% <0.00%> (-13.34%) ⬇️
docarray/array/mixins/getitem.py 79.36% <0.00%> (-11.12%) ⬇️
docarray/array/storage/base/getsetdel.py 85.81% <0.00%> (-5.41%) ⬇️
docarray/array/storage/weaviate/getsetdel.py 94.73% <0.00%> (-5.27%) ⬇️
docarray/array/storage/elastic/getsetdel.py 96.61% <0.00%> (-3.39%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@samsja samsja enabled auto-merge (squash) October 31, 2022 14:42
@samsja samsja merged commit fffedf5 into main Oct 31, 2022
@samsja samsja deleted the chore-fix-proto-hint branch October 31, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants