This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Updating vendoring for docker/docker to 5eca8382b03278dc42c228b3d14dec0909ce655b #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9ce655b Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
nishanttotla
force-pushed
the
update-docker-vendoring
branch
from
9d7c30a
to
e39220f
Compare
Adding github.com/docker/libtrust 9cbd2a1374f46905c68a4eb3694a130610adc62a Updating github.com/Microsoft/go-winio vendoring to v0.4.2 Updating vendoring for golang.org/x/sys 8f0908ab3b2457e2e15403d3697c9ef5cb4b57a9 Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
nishanttotla
force-pushed
the
update-docker-vendoring
branch
from
197a474
to
425ede8
Compare
nishanttotla
force-pushed
the
update-docker-vendoring
branch
2 times, most recently
from
b3b63e9
to
9749be0
Compare
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
nishanttotla
force-pushed
the
update-docker-vendoring
branch
from
9749be0
to
300d421
Compare
nishanttotla
changed the title
|
Ping @docker/core-swarm-maintainers PTAL. This is important to merge relatively soon, because it is blocking the release of 1.2.7. |
This was referenced Jun 19, 2017
nishanttotla
commented
Jun 20, 2017
| bImageNotFoundError113, _ := regexp.MatchString(`repository \S* not found`, err.Error()) | ||
| if (bImageNotFoundError || bImageNotFoundError113 || client.IsErrImageNotFound(err)) && !config.HaveNodeConstraint() { | ||
| bRepositoryNotFoundError1706, _ := regexp.MatchString(`repository does not exist`, err.Error()) |
There was a problem hiding this comment.
This is probably the only place where a review would be useful. The error message changed again so I needed to add an extra case for that.
cc @aluzzardi @wsong
aluzzardi
approved these changes
Jun 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was long due. This PR also vendors in additionally required dependencies, and updates types etc based on that.
Fix #2666.