Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Enable wrongly disabled tests and delete empty tests #2736

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/integration/api/info.bats
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ function teardown() {

@test "docker info - details" {
# details in docker info were introduced in docker 1.10, skip older version without
run docker info
if [[ "${output}" != *"Paused:"* ]]; then
run docker --version
if [[ "${output}" == "Docker version 1.9"* ]]; then
skip
fi

Expand Down
5 changes: 1 addition & 4 deletions test/integration/api/inspect.bats
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function teardown() {
[ "${#lines[@]}" -eq 2 ]
[[ "${lines[1]}" == *"test_container"* ]]

# inspect and verify
# inspect and verify
run docker_swarm inspect test_container
[ "$status" -eq 0 ]
[[ "${output}" == *"NetworkSettings"* ]]
Expand All @@ -42,9 +42,6 @@ function teardown() {
}

@test "docker inspect --format" {
# FIXME: Broken in docker master. See #717
skip

start_docker_with_busybox 2
swarm_manage
# run container
Expand Down
13 changes: 0 additions & 13 deletions test/integration/api/login.bats

This file was deleted.

13 changes: 0 additions & 13 deletions test/integration/api/logout.bats

This file was deleted.

13 changes: 0 additions & 13 deletions test/integration/api/push.bats

This file was deleted.

9 changes: 5 additions & 4 deletions test/integration/api/run.bats
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,11 @@ function teardown() {
[[ "${output}" == *"10.0.0.42"* ]]
}

@test "docker run --net-alias" {
# docker run --net-alias is introduced in docker 1.10, skip older version without --net-alias
@test "docker run --network-alias" {
# docker run --net-alias was introduced in docker 1.10, and later renamed to
# --network-alias. Only run tests for the latter.
run docker run --help
if [[ "${output}" != *"--net-alias"* ]]; then
if [[ "${output}" != *"--network-alias"* ]]; then
skip
fi

Expand All @@ -169,7 +170,7 @@ function teardown() {

docker_swarm network create -d bridge testn

docker_swarm run --name testc --net testn -d --net-alias=testa busybox sh
docker_swarm run --name testc --net testn -d --network-alias=testa busybox sh
run docker_swarm inspect testc
[[ "${output}" == *"testa"* ]]
}
Expand Down
8 changes: 4 additions & 4 deletions test/integration/discovery/token.bats
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ DISCOVERY=""
# token_cleanup
#}

# docker hub token service is down. This is not the recommended way of
# discovery. It's not prioritized on Docker hub. Disable the test for now.
# This is not the recommended way of discovery. It's not
# prioritized on Docker hub. Disable the test for now.
@test "token discovery: recover engines" {
skip

Expand All @@ -42,8 +42,8 @@ skip
retry 5 1 discovery_check_swarm_info
}

# docker hub token service is down. Since this is not the recommended way of
# discovery. It's not prioritized on Docker hub. Disable the test for now.
# This is not the recommended way of discovery. It's not
# prioritized on Docker hub. Disable the test for now.
@test "token discovery: watch for changes" {
skip

Expand Down