This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
add buffering/queueing function in default Group plugin #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI error will fix by #333 |
Current coverage is 69.08% (diff: 65.38%)@@ master #332 diff @@
==========================================
Files 30 30
Lines 1551 1569 +18
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1071 1084 +13
- Misses 373 380 +7
+ Partials 107 105 -2
|
chungers
reviewed
Dec 12, 2016
| @@ -242,6 +259,10 @@ func (s *scaler) converge() { | |||
|
|
|||
| s.scaled.CreateOne(nil) | |||
| }() | |||
| if s.maxParallelNum > 0 && (i+1)%int(s.maxParallelNum) == 0 { | |||
There was a problem hiding this comment.
How about extract this into a function on the scaler:
func (s *scaler) waitIfReachParallelLimit(current int, batch *sync.WaitGroup) {
// call wait on the batch if the current index reaches the parallel limit
}
and then call this as s.waitIfReachParallelLimit(i, &grp), and also after line 248 so that we can rate limit the Destroy calls as well?
chungers
reviewed
Dec 12, 2016
| @@ -13,7 +13,7 @@ func TestScaleUp(t *testing.T) { | |||
| defer ctrl.Finish() | |||
|
|
|||
| scaled := mock_group.NewMockScaled(ctrl) | |||
| scaler := NewScalingGroup(scaled, 3, 1*time.Millisecond) | |||
| scaler := NewScalingGroup(scaled, 3, 1*time.Millisecond, 0) | |||
There was a problem hiding this comment.
Can we add a new test or test this with maxParallel = 1? The test should pass fine since we are effectively serializing the CreateOne calls.
Signed-off-by: Yuji Oshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: Yuji Oshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: Yuji Oshima <yuji.oshima0x3fd@gmail.com>
YujiOshima
force-pushed
the
buffering_instance
branch
from
65eea5a to
dc29120
Compare
|
Please sign your commits following these rules: $ git clone -b "buffering_instance" git@github.com:YujiOshima/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353234656
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
chungers
approved these changes
Dec 13, 2016
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
* fixes docker-archive#332 Signed-off-by: Nicola Kabar <nicolaka@gmail.com> * adding DTR to DDC fixes docker-archive#332 Signed-off-by: Nicola Kabar <nicolaka@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #331
Add max-parallel flag to set maximum number of parallel provision.
Signed-off-by: Yuji Oshima yuji.oshima0x3fd@gmail.com