Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Automate building of Docker images #339

Merged
merged 3 commits into from
Dec 15, 2016

Conversation

chungers
Copy link
Contributor

This adds automation of building docker containers to ease development. The build infrakit/bundle image is for development only and not meant for production deployment.

David Chung added 2 commits December 14, 2016 16:58
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "circle_ci" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354357944
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: David Chung <david.chung@docker.com>
@codecov-io
Copy link

Current coverage is 68.83% (diff: 100%)

Merging #339 into master will increase coverage by 0.06%

@@             master       #339   diff @@
==========================================
  Files            30         30          
  Lines          1569       1569          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1079       1080     +1   
+ Misses          383        382     -1   
  Partials        107        107          

Powered by Codecov. Last update 159cfe0...c1663c1

@chungers
Copy link
Contributor Author

I need to merge this in so that circle can build images on master.

@chungers chungers merged commit 112156b into docker-archive:master Dec 15, 2016
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
* Bump the number of IPs and timeout period

Signed-off-by: Ken Cochrane <KenCochrane@gmail.com>

* Updated with new values

Signed-off-by: Ken Cochrane <KenCochrane@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants