This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Use plugin.Name instead of string in all plugin configurations #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Chung <david.chung@docker.com>
chungers
changed the title
Current coverage is 65.15% (diff: 72.22%)@@ master #362 diff @@
==========================================
Files 19 45 +26
Lines 816 2167 +1351
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 444 1412 +968
- Misses 314 610 +296
- Partials 58 145 +87
|
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
Release of Azure beta9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize on the use of
plugin.Nametype for all plugin configs, instead ofstring.This provides a common, standardized handling of plugin references and makes the code easier to read.
Signed-off-by: David Chung david.chung@docker.com