This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Template package cleanup + more tests #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2017 23:08
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Current coverage is 65.49% (diff: 73.46%)@@ master #366 diff @@
==========================================
Files 47 47
Lines 2266 2275 +9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1468 1490 +22
+ Misses 638 620 -18
- Partials 160 165 +5
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopefully gives the
pkg/templatepackage more test coverage because previously this package has one of the lower coverages. Exported template function names have been renamed and refactored into exported functions for testability and consistency.