Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

support headers in template fetch #444

Merged
merged 7 commits into from
Mar 24, 2017

Conversation

chungers
Copy link
Contributor

This will make it possible to use the templates to fetch metadata on GCP: https://cloud.google.com/compute/docs/storing-retrieving-metadata#querying

Signed-off-by: David Chung david.chung@docker.com

David Chung added 2 commits March 24, 2017 00:03
Signed-off-by: David Chung <david.chung@docker.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "template-headers" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353799136
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

David Chung added 4 commits March 24, 2017 00:08
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@codecov
Copy link

codecov bot commented Mar 24, 2017

Codecov Report

Merging #444 into master will increase coverage by 0.5%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #444     +/-   ##
=========================================
+ Coverage   69.81%   70.31%   +0.5%     
=========================================
  Files          74       68      -6     
  Lines        4343     3925    -418     
=========================================
- Hits         3032     2760    -272     
+ Misses       1034      925    -109     
+ Partials      277      240     -37
Impacted Files Coverage Δ
pkg/template/util.go
pkg/template/defaults.go
pkg/template/help.go
pkg/broker/server/sse.go 74.78% <0%> (+1.68%) ⬆️
pkg/manager/manager.go 66.06% <0%> (+2.42%) ⬆️
pkg/broker/client/sse.go 68.6% <0%> (+3.48%) ⬆️
pkg/manager/group_plugin_impl.go 19.14% <0%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd74ee6...5b35f00. Read the comment docs.

@chungers chungers merged commit a8b26d3 into docker-archive:master Mar 24, 2017
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Signed-off-by: Ken Cochrane <KenCochrane@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants