-
Notifications
You must be signed in to change notification settings - Fork 262
Conversation
@ndegory You need to edit vendor.conf and update vendored packages. |
|
||
func TestInstanceLifecycle(t *testing.T) { | ||
defaultHeaders := map[string]string{"User-Agent": "InfraKit"} | ||
cli, err := client.NewClient("unix:///var/run/docker.sock", "1.25", nil, defaultHeaders) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be you cannot access docker.sock
in CircleCI test.
thanks for the review @YujiOshima , I'll take care about it. |
Please sign your commits following these rules: $ git clone -b "instance-docker" git@github.com:ndegory/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353663176
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
tags = map[string]string{"group": "workers"} | ||
) | ||
|
||
func TestInstanceLifecycle(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CircleCI can't really run tests with docker reliably or at all. Instead of removing this test, do this....
import testutil "github.com/docker/infrakit/pkg/testing"
- Add a check here:
if testutil.SkipTests("docker") {
t.SkipNow()
}
This will skip the test on CircleCI because there's an environment variable set when running tests on CircleCI (see the circle.yml
file):
SKIP_TESTS: "docker,etcd"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the tip @chungers
ee17d0c
to
4add813
Compare
4add813
to
5ebe3db
Compare
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
==========================================
- Coverage 63.9% 56.27% -7.64%
==========================================
Files 38 41 +3
Lines 2344 2662 +318
==========================================
Hits 1498 1498
- Misses 693 1011 +318
Partials 153 153
Continue to review full report at Codecov.
|
5ebe3db
to
2d602d8
Compare
2d602d8
to
29585e6
Compare
29585e6
to
3ba9330
Compare
Signed-off-by: Nicolas Degory <ndegory@axway.com>
3ba9330
to
619bd06
Compare
Added ability to pick the size and type of the EBS volume for manager…
Added ability to pick the size and type of the EBS volume for manager…
Docker instance plugin for InfraKit
Can be used with any Docker images but can also be used with Docker in Docker containers in conjunction with the Swarm vanilla plugin.