Terraform plugin fails to describe instance by tag

[kaufers]

The terraform instance plugin's DescribeInstances function may fail if there are multiple groups. The resources types are parsed from the .tf.json files and stored in a map key'd by the resource type. During the tag match filtering, if a tag does not match then (currently) no other resources of the same type are processed.

This is exposed when there are multiple groups since the group name is included in a tag.

Closes #493

Signed-off-by: Steven Kaufer kaufer@us.ibm.com

[codecov]

Codecov Report

Merging #495 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
- Coverage   57.64%   57.51%   -0.13%     
==========================================
  Files          32       57      +25     
  Lines        2014     3771    +1757     
==========================================
+ Hits         1161     2169    +1008     
- Misses        710     1323     +613     
- Partials      143      279     +136

Impacted Files	Coverage Δ
examples/instance/terraform/plugin.go	61.83% <100%> (+1.76%)	⬆️
pkg/rpc/mux/reverse_proxy.go	39.43% <0%> (ø)
pkg/template/defaults.go	71.42% <0%> (ø)
pkg/types/hierarchy.go	80% <0%> (ø)
pkg/types/path.go	84.8% <0%> (ø)
pkg/util/etcd/v3/etcd.go	28.57% <0%> (ø)
pkg/types/object.go	77.77% <0%> (ø)
pkg/types/reflect.go	73.64% <0%> (ø)
pkg/store/swarm/swarm.go	67.27% <0%> (ø)
pkg/spi/event/types.go	64.1% <0%> (ø)
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce06e23...ce18405. Read the comment docs.

[chungers]

LGTM. Thanks!