This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 262
Support for multiple remotes in infrakit CLI #528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Please sign your commits following these rules: $ git clone -b "work-0504" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354613824
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: David Chung <david.chung@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 56.73% 56.73%
=======================================
Files 57 57
Lines 3904 3904
=======================================
Hits 2215 2215
Misses 1403 1403
Partials 286 286 Continue to review full report at Codecov.
|
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
…re_public_beat Add final changes for Azure v1.13.0-rc2-beta12 release
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Oct 1, 2017
…re_public_beat Add final changes for Azure v1.13.0-rc2-beta12 release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the use of
-H
to connect to remote hosts easier:$INFRAKIT_HOME/hosts
is used to determine the url of the remote infrakit daemons to connect to. Multiple hosts can be specified in one file:INFRAKIT_HOST
is used to determine which hostname to use. If the environment variable is not set, then local, unix socket discovery is used.This is the order of determining where to connect:
-H
is set, it takes priority ==> continueINFRAKIT_HOME
/hostsINFRAKIT_HOST
valueINFRAKIT_HOST
env is not set ==> do nothing; this matches current functionality