Append LogicalID to Softlayer instance hostname

[kaufers]

Currently, the hostname for the Softlayer terraform resource is either the instance name (ie, "instance-12345") if the @hostname_prefix property is not set; else it's formatted as <@hostname_prefix>-<timestamp> (ie, "given-prefix-12345).

This approach makes sense for workers but having a more predictable naming scheme for managers would be more usable. This commit updates the naming scheme to use the LogicalID (if set) instead of the timestamp when generating the hostname.

See issue #555.

Note that the instance name remains unchanged; it's only the hostname property that is being updated.

Signed-off-by: Steven Kaufer kaufer@us.ibm.com

[codecov]

Codecov Report

Merging #558 into master will decrease coverage by 0.02%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   56.68%   56.66%   -0.03%     
==========================================
  Files          57       57              
  Lines        3964     3969       +5     
==========================================
+ Hits         2247     2249       +2     
- Misses       1431     1432       +1     
- Partials      286      288       +2

Impacted Files	Coverage Δ
examples/instance/terraform/plugin.go	66.56% <72.72%> (-0.43%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f552304...9b3e77a. Read the comment docs.