-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[17.06] backport various completion script updates #104
[17.06] backport various completion script updates #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping @albers PTAL
It's really hard to keep up with all the changes in Docker. But I figured out how to work with this repo and found a hack that gets the completion script into the dev container. moby/moby#33801 is not present here. I verified the changes successfully. All features are present. The script can be loaded with ancient bash version as well (MacOS). One point though: The implementation of |
can we also pull in docker/cli#321 (was just merged)? |
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit e4f9ad77c8de298af11a57f9ca89c88fa3d62181) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 8b99b65ca82534edca786a9e3a61d77297626690) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Also fixes a wrong option: `--arg` should be `--args`. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit e0462e8472af1f0835104651e062b35756901d59) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
…from` Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 22579ba56cd5da8fa2808f1041b9dbc65738d40a) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
`--internal` is a boolean option. It was falsely treated as non-boolean. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 12dc9eb11f3e6911a024008dc664fd124f8eb36f) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 8baef1098ecef546040b7582344d4f08aab08dc9) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit f0f71505377ef2af5e51ee07b1b054cd83ec3886) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 71dd0e0b668a5755d89815a9c310c2370680c1dc) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit fa0f470a5f43c11b611afcdfc47d1d985f98553c) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 5bd00a563e9cc013d9d67e4770cae2be65963f98) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit fa4dc8820af82052834d96704f927ec789530be1) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The `--network` option is only available for `docker service create`. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit e7e77b5e65062006d1e858ab2d4a1cde2651abf2) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
I brought in docker/cli@e7e77b5 and rebased to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still LGTM
Update go to 1.10.2 Upstream-commit: 1aa5fac Component: packaging
[18.09] Vendor swarmkit to 6186e40 Upstream-commit: 4fc9786f7869a823962b7da6c876288b37d8da54 Component: engine
Update go to 1.10.2
backport completion script fixes:
docker network create --ingress
docker/cli#239 Add bash completion fordocker network create --ingress
label
filter ofprune
commands docker/cli#246 Add bash completion forlabel
filter ofprune
commandsservice create|update --entrypoint
docker/cli#247 Add bash completion forservice create|update --entrypoint
network create --scope|--config-only|config-from
docker/cli#248 Add bash completion fornetwork create --scope|--config-only|config-from
network create --internal
docker/cli#249 Fix bash completion fornetwork create --internal
service create --detach
docker/cli#250 Add bash completion forservice create --detach
service create|update (update|rollback)-order
docker/cli#256 Add bash completion forservice create|update (update|rollback)-order
service create|update --network-(add|rm)
docker/cli#257 Add bash completion forservice create|update --network-(add|rm)
swarm ca
docker/cli#268 Add bash completion forswarm ca
swarm init|join --data-path-addr
docker/cli#269 Fix bash completion forswarm init|join --data-path-addr
service update --network
docker/cli#321 Remove bash completion forservice update --network
with cherry-pick (each PR only had one commit):