This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[18.03] disallow attaching ingress network #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @andrewhsu @fcrisciani @anshulpundir PTAL |
|
1 failure on Windows; doesn't look related; https://jenkins.dockerproject.org/job/docker-ce-pr-WoW-RS1/803/console |
Ingress network should not be attachable Ingress network is a special network used only to expose ports. For this reason the network cannot be explicitly attached during service create or service update Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contains no changes for the CLI, but keeps the version in sync with engine Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
18.03-swarmkit-ingress-attach
branch
from
32a35da
to
dbe2a19
Compare
|
Rebased, to get rid of the commits from #451 |
|
It's failing in the |
Closed
docker-jenkins
pushed a commit
that referenced
this pull request
Jan 23, 2020
[19.03] vendor: update buildkit to 926935b5 Upstream-commit: bd9e7fca87d36a0ac9c28827f3ca3bb491b3b898 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 31, 2020
…ngress-attach [18.03] disallow attaching ingress network
docker-jenkins
pushed a commit
that referenced
this pull request
Apr 14, 2020
Bump Golang 1.13.10 Upstream-commit: 1648bd1 Component: packaging
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Bump Golang 1.13.10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in moby/swarmkit#2523; moby/swarmkit@49a9d7f...11d7b06
CLI vendoring is also updated, but did not bring in changes