This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Fix Git component #791
Closed
Fix Git component #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different Git packages use different installation paths, which, in their turn may also be redefined by the user. Moreover, even if Git is installed there is no guarantee that the Bash component is also present. So there is little sense to depend on Git bash or to consider it to be at any specific location. Resolves: docker-archive#343, docker-archive#335, docker-archive#640, docker-archive#466, docker-archive#687, docker-archive#636. Signed-off-by: Maxim Plevako <mplevako@gmail.com>
Different Git packages use different installation paths, which, in their turn, may also be redefined by the user. Also, many packages don't modify the registry and even those that do use different registry branches, entries and names. Therefore it is unreliable to check for existence of any assumed paths, files or registry entries to detect whether Git is already installed. Docker itself assumes that the path to the git command is present in the PATH environment variable so it is enough to use the where command which is present in all Windows OSes required by Docker. Resolves: docker-archive#226, docker-archive#246, docker-archive#295, docker-archive#276. Signed-off-by: Maxim Plevako <mplevako@gmail.com>
mplevako
force-pushed
the
fix_git_component
branch
from
0bee2e4 to
7ac671f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency on Git bash and change the way a Git installation is detected.
Resolves: #343, #335, #640, #466, #687, #636 and #226, #246, #295, #276.