Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azul Zulu images #2320

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

FDelporte
Copy link

@FDelporte FDelporte commented May 5, 2023

Proposal to add the Azul Zulu images as official images.

Relates to docker-library/official-images#14593
Relates to docker-library/official-images#16141

Copy link
Contributor

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest docker-library PR, docker-library/official-images#16141, appears to be adding azul-zulu, so the path of these files should be updated from zulu/ to azul-zulu/.

zulu/content.md Outdated Show resolved Hide resolved
Comment on lines 16 to 35
* Azul Zulu 17 based on Ubuntu:
```
docker run -it --rm azul/azul-zulu:17 java -version
```
* Azul Zulu 17 based on Debian:
```
docker run -it --rm azul/azul-zulu-debian:17 java -version
```
* Azul Zulu 17 based on CentOS:
```
docker run -it --rm azul/azul-zulu-centos:17 java -version
```
* Azul Zulu 17 based on Alpine:
```
docker run -it --rm azul/azul-zulu-alpine:17 java -version
```
* Azul Zulu 17 based on Distroless:
```
docker run -it --rm azul/azul-zulu-distroless:17 --version
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commands still all reference non-existent images. The PR to create a new DOI, docker-library/official-images#14593 , would create the images in the repository azul-zulu-openjdk, so the images would look something like azul-zulu-openjdk:17-ubuntu, i.e., there is no namespace and the base image type appears in the tag, not the repository.

Copy link
Author

@FDelporte FDelporte Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct @whalelines, I modified this pull request to align with DOI merge request docker-library/official-images#16141.

But this means both pull requests should get approved and published together?

FYI as mentioned in the last comment in docker-library/official-images#14593, the correct merge request for DOI Azul Zulu is docker-library/official-images#16141

@geertjanw
Copy link

great, thank you, and can you also merge it, @LaurentGoderre?

@tianon
Copy link
Member

tianon commented May 17, 2024

Your continued patience is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants