[FIX] arm64 libvips (broken sqlite build) #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Downgrades python3 to python2 to support broken sqlite3 build scripts when arm/arm64 fails over to manual build - Upgrades 4/debian to bullseye for arm64 dependency compatibility
|
😩 I thought for sure this can't be right, given Python 2 has been totally EOL for two years now and deprecated for much longer than that, but sure enough, I found TryGhost/node-sqlite3#1516 -- in the "good news" column we have TryGhost/node-sqlite3#1441 (and TryGhost/node-sqlite3#1443, and others) which fixed the issue by updating to a newer dependency on |
|
Thanks for the fix -- hopefully we'll get a new |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 13, 2022
Changes: - docker-library/ghost@ae48809: Merge pull request docker-library/ghost#281 from ianmclinden/fix-arm-arm64-sharp - docker-library/ghost@a398151: [FIX] arm64/arm libvips (broken sqlite build)
This was referenced Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
On non-amd64 platforms the 4/*/Dockerfile will fail to install sqlite3 from node, and failover to manually building it. Changes to the node-sqlite3 build scripts now include python2 syntax that causes python3 build errors. This can be fixed by downgrading to python2. Debian support on arm64 necessitates bumping to bullseye for dependency requirements.
The following builds now complete successfully:
This may need more deployment testing of non-arm images.
CHANGES:
RELATED: