-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lua support. #38
Add lua support. #38
Conversation
Very nice work. Looks like we can get Lua 5.3 from jessie-backports, so we can just swap the Debian Dockerfiles to be from |
Cool, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
On Debian you'll need |
Yeah, there are a few other minor changes that need to be made too (whitespace, cleanup), which I've got locally in progress. 👍 Thanks @yajo! |
... and of course, today http://www.haproxy.org decides that it should refuse our connections 😢 |
Seems to be the same issue as in https://www.mail-archive.com/haproxy@formilux.org/msg24512.html |
@tianon Appears to be working now. |
…tency/maintainability (whitespace, etc)
Rough size comparisons, for reference:
|
&& mkdir -p /usr/src/haproxy \ | ||
&& tar -xzf haproxy.tar.gz -C /usr/src/haproxy --strip-components=1 \ | ||
&& rm haproxy.tar.gz \ | ||
&& make -C /usr/src/haproxy \ | ||
\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why this (I have seen it below too a few times). Is it for adding a white line? Did you know Dockerfile's white/comment lines are ignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we like to have some whitespace to separate sections of the RUN line. The Dockerfile parser does currently ignore empty lines, but it was "fixed" to not do so in moby/moby#24725 and reverted because of moby/moby#29005 in moby/moby#29064, but still planned to be deprecated with moby/moby#29161. As far as I know, comments in RUN lines will stay even if empty lines get removed.
I see why it got smaller! You switched to wget and it doesn't leave behind stuff after the |
- `bash`: 4.4.7 - `golang`: 1.8rc2 - `haproxy`: add Lua support (docker-library/haproxy#38) - `postgres`: (mostly) arbitrary `--user` support (docker-library/postgres#253) - `python`: 3.4.6
Following #28 (comment), there you have Lua support for 1.6+.
It must be Lua >= 5.3, so I cannot use system packages for now. Debian and Alpine have older packaged versions.
@Tecnativa