Add templates and remove manual Lua install #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Apr 6, 2018
1.7/Dockerfile
Outdated
| @@ -21,6 +22,7 @@ RUN set -x \ | |||
| liblua5.3-dev \ | |||
| libpcre3-dev \ | |||
| libssl-dev \ | |||
| zlib1g-dev \ | |||
| make \ | |||
| wget \ | |||
tianon
reviewed
Apr 6, 2018
Dockerfile-debian.template
Outdated
| libssl-dev \ | ||
| zlib1g-dev \ | ||
| make \ | ||
| wget \ |
There was a problem hiding this comment.
I guess the :sort should really happen down here. 😇
tianon
reviewed
Apr 6, 2018
update.sh
Outdated
| travisEnv='\n - VERSION='"$version VARIANT=$variant$travisEnv" | ||
| done | ||
|
|
||
| if [ "$version" = '1.5' ]; then | ||
| for dockerfile in "$version/Dockerfile" "$version/$variant/Dockerfile"; do |
There was a problem hiding this comment.
Where does $variant come from here?
|
🍏 📗 💚 🥗 🇬🇱 green! |
tianon
approved these changes
Apr 23, 2018
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Apr 26, 2018
- `cassandra`: better IP detection (docker-library/cassandra#146) - `docker`: 18.03.1-ce, 18.05.0-ce-rc1 - `drupal`: 8.5.3, 8.4.8, 7.59 - `ghost`: 1.22.4 - `haproxy`: better Lua install, stretch, Alpine 3.7 (docker-library/haproxy#63) - `mariadb`: `5.5.60+maria-1~wheezy` - `matomo`: `latest` - `mongo`: 3.7.7 - `openjdk`: windows ojdkbuild 1.8.0.171-1 - `percona`: `5.7.21-21-3.jessie` - `php`: 7.2.5, 7.0.30 - `piwik`: `latest` - `postgres`: Debian Stretch (docker-library/postgres#437), Alpine 3.7 (docker-library/postgres#436) - `pypy`: pip 10.0.1 (docker-library/pypy#22) - `python`: fix Windows build via TLS 1.2 (docker-library/python#279), Python 2 `PYTHONIOENCODING=UTF-8` (docker-library/python#278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61.
1.5should be materially unchanged. It'll be just the swap towgetand the explicit install ofzlib1g-devwhich was already assumed to be installed withUSE_ZLIB=1(it is a dependency oflibssl-devin jessie but not stretch).