Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mysql #12743

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Update mysql #12743

merged 1 commit into from
Jul 5, 2022

Conversation

tianon
Copy link
Member

@tianon tianon commented Jul 5, 2022

Changes:

- docker-library/mysql@f8d76ae: Merge pull request docker-library/mysql#867 from infosiftr/oracle
- docker-library/mysql@6cb7337: Merge pull request docker-library/mysql#866 from infosiftr/bullseye
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Diff for 2d9acd8:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 9576afd..ce19dd1 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,23 +1,23 @@
 Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon), Joseph Ferguson <yosifkit@gmail.com> (@yosifkit)
 GitRepo: https://github.com/docker-library/mysql.git
 
-Tags: 5.7.38, 5.7, 5, 5.7.38-debian, 5.7-debian, 5-debian
-GitCommit: b22945da0ed9f152485cc68ff7565204e8d37db4
-Directory: 5.7
-File: Dockerfile.debian
-
-Tags: 5.7.38-oracle, 5.7-oracle, 5-oracle
+Tags: 5.7.38, 5.7, 5, 5.7.38-oracle, 5.7-oracle, 5-oracle
 GitCommit: 35b90084fed1f790832d58447cb7cea1251710bd
 Directory: 5.7
 File: Dockerfile.oracle
 
-Tags: 8.0.29, 8.0, 8, latest, 8.0.29-debian, 8.0-debian, 8-debian, debian
+Tags: 5.7.38-debian, 5.7-debian, 5-debian
 GitCommit: b22945da0ed9f152485cc68ff7565204e8d37db4
-Directory: 8.0
+Directory: 5.7
 File: Dockerfile.debian
 
-Tags: 8.0.29-oracle, 8.0-oracle, 8-oracle, oracle
+Tags: 8.0.29, 8.0, 8, latest, 8.0.29-oracle, 8.0-oracle, 8-oracle, oracle
 Architectures: amd64, arm64v8
 GitCommit: b22945da0ed9f152485cc68ff7565204e8d37db4
 Directory: 8.0
 File: Dockerfile.oracle
+
+Tags: 8.0.29-debian, 8.0-debian, 8-debian, debian
+GitCommit: 6cb73371396bdfcc048a701fa4a4c9e3eee4fde4
+Directory: 8.0
+File: Dockerfile.debian
diff --git a/mysql_debian/Dockerfile.debian b/mysql_debian/Dockerfile.debian
index 96c604e..5e6d5f7 100644
--- a/mysql_debian/Dockerfile.debian
+++ b/mysql_debian/Dockerfile.debian
@@ -4,7 +4,7 @@
 # PLEASE DO NOT EDIT IT DIRECTLY.
 #
 
-FROM debian:buster-slim
+FROM debian:bullseye-slim
 
 # add our user and group first to make sure their IDs get assigned consistently, regardless of whatever dependencies get added
 RUN groupadd -r mysql && useradd -r -g mysql mysql
@@ -63,9 +63,9 @@ RUN set -eux; \
 	rm -rf "$GNUPGHOME"
 
 ENV MYSQL_MAJOR 8.0
-ENV MYSQL_VERSION 8.0.29-1debian10
+ENV MYSQL_VERSION 8.0.29-1debian11
 
-RUN echo 'deb [ signed-by=/etc/apt/keyrings/mysql.gpg ] http://repo.mysql.com/apt/debian/ buster mysql-8.0' > /etc/apt/sources.list.d/mysql.list
+RUN echo 'deb [ signed-by=/etc/apt/keyrings/mysql.gpg ] http://repo.mysql.com/apt/debian/ bullseye mysql-8.0' > /etc/apt/sources.list.d/mysql.list
 
 # the "/var/lib/mysql" stuff here is because the mysql-server postinst doesn't have an explicit way to disable the mysql_install_db codepath besides having a database already "configured" (ie, stuff in /var/lib/mysql/mysql)
 # also, we set debconf keys to make APT a little quieter

Relevant Maintainers:

@tianon tianon merged commit 8544c55 into docker-library:master Jul 5, 2022
@tianon tianon deleted the mysql branch July 5, 2022 18:14
@bryan-lee-git
Copy link

Hello there! Just wanted to let you know of an issue I experienced related to this PR. This PR changes the default image that gets used from debian to oracle. This will break any dockerfiles using the mysql:5.7 base image followed by steps like apt-get and result in errors like this /bin/sh: apt-get: command not found. Had to specify mysql:5.7-debian instead of just mysql:5.7 to fix the issue.

@bryan-lee-git
Copy link

bryan-lee-git commented Jul 11, 2022

After looking at the other issues regarding this update, I have switched over to just using the 5.7 image with oracle and changing apt-get to yum. However, I will say that making a sweeping change like this to an image that has used debian as the default for a long period of time seems like a questionable decision given how widely used this image is.

@khassad
Copy link

khassad commented Aug 11, 2022

I will just add to this that this unwise and unannounced/undocumented change had some major consequences for some of us around.

The switch to oracle from debian introduces some breaking change which in our case led to badly corrupted database and hours of downtime. What was due to be a minor mysql version upgrade in the 8.0 branch turned into a business-critical nightmare.

The lesson here is clear : when your upstream supplier is unreliable, switch away from it !
Time for us to move away from mysql and oracle business.

I don't think oracle cares for its user base nor monitor the feedback but I write this here for others, in case our experience can save them some sweat and blood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants