Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Testsuite for Joomla #14630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented May 11, 2023


_cli() {
docker exec -u www-data "$cid" php installation/joomla.php install -n \
--site-name="test-$RANDOM" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically I advise against using random variables in unit tests - you want them to be perfectly replicable on each run

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In these tests, we encourage random variance because it usually increases the chances that the test is actually testing something meaningful instead of just hitting the happy path every time (for example, putting a "default" value in the test that just happens to work because it matches the default of the image when the image wouldn't handle a non-default value, for example).

@LaurentGoderre
Copy link
Member

Since most of the test have the same setup logic, it might be desirable to convert them to use bash functions with parameters for the varying parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add runtime tests
4 participants